Bug 954 – Dovecot authentication protocol update - Exim fails on unknown server commands

Bug 954 - Dovecot authentication protocol update - Exim fails on unknown server commands


Summary:	Dovecot authentication protocol update - Exim fails on unknown server commands

Status:	RESOLVED FIXED

Product:	Exim
Classification:	Unclassified
Component:	SMTP Authentication
Version:	N/A
Hardware:	Other Windows

Importance:	medium bug
Target Milestone:	Exim 4.77
Assigned To:	Unallocated Bugs
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-01-25 12:39 UTC by exim-bugs
Modified:	2011-05-19 12:37 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
patch to fix bug - jumps over COOKIE (507 bytes, patch) 2010-01-25 12:40 UTC, exim-bugs	Details \| Diff
same as previously, but now commited into my local git repo. (732 bytes, text/plain) 2010-01-25 13:05 UTC, exim-bugs	Details
patch to fix bug - only inspects known commands (46 bytes, text/plain) 2010-01-28 09:09 UTC, exim-bugs	Details
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description exim-bugs 2010-01-25 12:39:06 UTC

In version 1.1 of Dovecot authentication protocol, a new server keyword is introduced (COOKIE). This new keyword confused Exim and caused authentication to fail. I attach a quick fix (COOKIE is not needed for SMTP authentication anyway).

Comment 1 exim-bugs 2010-01-25 12:40:19 UTC

Created attachment 373 [details]
patch to fix bug - jumps over COOKIE

Comment 2 exim-bugs 2010-01-25 13:05:30 UTC

Created attachment 374 [details]
same as previously, but now commited into my local git repo.

Comment 3 exim-bugs 2010-01-28 09:09:24 UTC

Created attachment 376 [details]
patch to fix bug - only inspects known commands

I reworked the patch. Exim will ignore commands it doesn't care about. This will reduce chance of surpises if protocol version 1.2 introduces another keyword. The patch is against 91b6966868b34442c537fee64204ed87a33ad8b0 and available here:

http://km.krot.org/code/exim-dovecot-1.1.diff

Previous attachments can be ignored.

Comment 4 Unallocated Bugs 2010-03-05 16:11:11 UTC

CVS commit by nm4:

Fix for unknown responses from Dovecot authenticator.  Fixes: bug#954

--- CVS commit summary ---
1.604  1.605  +3 -0    -  exim/exim-doc/doc-txt/ChangeLog
1.11   1.12   +12 -24  -  exim/exim-src/src/auths/dovecot.c